feat: support configurable web terminal rendering #10095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmct
reviewed
Oct 6, 2023
14aae39 to
b996c04
Compare
code-asher
approved these changes
Oct 6, 2023
| }>; | ||
|
|
||
| const TerminalPage: FC<TerminalPageProps> = ({ renderer }) => { | ||
| const TerminalPage: FC = () => { |
There was a problem hiding this comment.
I think we are getting a test failure because the test looks for HTML elements so it relies on the dom renderer being used (see webTerminal.spec.ts). Maybe we can start the e2e tests with dom set as the renderer? Looks like we would do that in playwright.config.ts if I understand correctly.
- Added a deployment option for configuring web terminal rendering. Valid values are 'webgl', 'canvas', and 'dom'.
0679c29 to
199bde3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10082