feat: only display license warnings to privileged users #10096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
approved these changes
Oct 9, 2023
Emyrk
reviewed
Oct 10, 2023
Comment on lines
+845
to
+849
| // Don't show warning to regular users. | ||
| if len(user.Roles) > 0 { | ||
| for _, w := range entitlements.Warnings { | ||
| _, _ = fmt.Fprintln(i.Stderr, pretty.Sprint(cliui.DefaultStyles.Warn, w)) | ||
| } |
There was a problem hiding this comment.
This isn't really ideal. Checking the roles length would fail if we added back in org-member roles for example.
A better check is to check the capability of a user. Such as checking if the user can read deploymentValues or something.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9350
This does not address entitlement errors as it appears we aren't currently displaying those anyway and it's unclear if we've come to a consensus on whether we are displaying those to all users or not.