Skip to content

feat: show user limit on active users chart #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2023
Merged

feat: show user limit on active users chart #10101

merged 7 commits into from
Oct 9, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Oct 6, 2023 •
edited
Loading

Related: #9983

This PR shows "user limit" line on active users charts. User limit is read from Entitlements.

I had to install a plugin for annotations.

Screenshot 2023-10-06 at 12 10 56 Screenshot 2023-10-06 at 13 26 20

@mtojek mtojek self-assigned this Oct 6, 2023
@mtojek mtojek requested a review from BrunoQuaresma October 6, 2023 11:47
@mtojek mtojek marked this pull request as ready for review October 6, 2023 11:47
@mtojek mtojek mentioned this pull request Oct 6, 2023
Closed
BrunoQuaresma
BrunoQuaresma approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I jus would make the line white or gray-is. Purple does not match too much our current colors.

@mtojek
Copy link
Member Author

mtojek commented Oct 9, 2023

Ok, I made it gray!

Screenshot 2023-10-09 at 13 27 29

@mtojek mtojek merged commit c6cf719 into main Oct 9, 2023
@mtojek mtojek deleted the 9983-user-limit-2 branch October 9, 2023 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @BrunoQuaresma