chore(site): remove create template xservice #10112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Oct 6, 2023
Comment on lines
+163
to
+172
| export class JobError extends Error { | ||
| public job: ProvisionerJob; | ||
| public version: TemplateVersion; | ||
|
|
||
| constructor(job: ProvisionerJob, version: TemplateVersion) { | ||
| super(job.error); | ||
| this.job = job; | ||
| this.version = version; | ||
| } | ||
| } |
There was a problem hiding this comment.
do we have somewhere more general we can put these sorts of errors? not crazy about this being tucked away in queries/
There was a problem hiding this comment.
We don't but I'm open to it if you have any place or organization in mind.
There was a problem hiding this comment.
maybe util/errors or something? I don’t tend to like util/ folders, but it’d be slightly more reusable there until we think of somewhere better
There was a problem hiding this comment.
Hm... Idk but I feel it is kinda of far from where it is used since it is only used there - for now and probably it will be the only place where it makes sense IMO.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of removing the create template service, I split the page into three views to represent each possible action:
I think with this, things are easier to reason about.
PS: I tried my best not to create deep abstractions so for now, I would rather have more duplicate code - but easier to understand - than very low code that is hard to change later.
Related to: #9940