Skip to content

feat: add footer to the login page #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen Shot 2022-04-14 at 16 27 26

Closes #700

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 14, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 14, 2022 19:28
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1012 (9b70dec) into main (76f8ff9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
- Coverage   67.08%   67.05%   -0.04%     
==========================================
  Files         256      256              
  Lines       14986    14987       +1     
  Branches      136      136              
==========================================
- Hits        10053    10049       -4     
- Misses       3938     3945       +7     
+ Partials      995      993       -2     
Flag Coverage Δ
unittest-go-macos-latest 53.59% <ø> (-0.12%) ⬇️
unittest-go-postgres- 66.74% <ø> (+0.02%) ⬆️
unittest-go-ubuntu-latest 56.20% <ø> (-0.13%) ⬇️
unittest-go-windows-2022 53.07% <ø> (+0.06%) ⬆️
unittest-js 62.97% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
site/src/pages/login.tsx 90.90% <100.00%> (+0.43%) ⬆️
coderd/parameter/compute.go 76.29% <0.00%> (-4.45%) ⬇️
provisionerd/provisionerd.go 79.85% <0.00%> (-2.95%) ⬇️
peer/conn.go 79.18% <0.00%> (-1.27%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
coderd/database/queries.sql.go 83.86% <0.00%> (-0.21%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
provisioner/terraform/provision.go 68.54% <0.00%> (+0.43%) ⬆️
coderd/workspaceagents.go 59.82% <0.00%> (+1.33%) ⬆️
peer/channel.go 84.97% <0.00%> (+1.73%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f8ff9...9b70dec. Read the comment docs.

@BrunoQuaresma BrunoQuaresma merged commit 1c55572 into main Apr 15, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/700/add-footer-to-login-page branch April 15, 2022 12:38
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Copyright and Version to the footer of the login page
4 participants