feat(cli): add --parameter flag to exp scaletest command #10132
Conversation
| richParameters, err := prepWorkspaceBuild(inv, client, prepWorkspaceBuildArgs{ | ||
| Action: WorkspaceCreate, | ||
| Template: tpl, | ||
| NewWorkspaceName: "scaletest-%", // TODO: the scaletest runner will pass in a different name here. Does this matter? |
There was a problem hiding this comment.
@mtojek Does the value here only matter for showing the plan output?
There was a problem hiding this comment.
Yes, only for dry-run purposes. Not sure what happens if there is a workspace with such name exists. In the worst case, you can append a random number.
| richParameters, err := prepWorkspaceBuild(inv, client, prepWorkspaceBuildArgs{ | ||
| Action: WorkspaceCreate, | ||
| Template: tpl, | ||
| NewWorkspaceName: "scaletest-%", // TODO: the scaletest runner will pass in a different name here. Does this matter? |
There was a problem hiding this comment.
Yes, only for dry-run purposes. Not sure what happens if there is a workspace with such name exists. In the worst case, you can append a random number.
| @@ -525,6 +525,8 @@ func (r *RootCmd) scaletestCreateWorkspaces() *clibase.Cmd { | |||
|
|
|||
| useHostUser bool | |||
|
|
|||
| parameterFlags workspaceParameterFlags | |||
There was a problem hiding this comment.
FYI This may also pull --build-options, not sure if you want to support them too. Probably not.
There was a problem hiding this comment.
I don't see a need at present. We don't rebuild workspaces in this command, only create.
This PR adds support for passing parameters to workspaces built by
exp scaletest.