feat: add shebang support to scripts #10134
Conversation
This enables much greater portability!
4f7c84b to
bae3a1e
Compare
|
@mafredri going to merge this, but feel free to review post and I'll address anything! |
| } else { | ||
| args = []string{} | ||
| } | ||
| args = append(args, caller, script) |
There was a problem hiding this comment.
Hmm, I guess this still assumes that the shebang is for a shell that supports -c or /c.
What if this was the contents:
#!/usr/bin/env node
console.log('hi');
This works on a typical Unix system, but here it would trigger the --check flag for node. I suppose to truly replicate shebang, we should also write script to a file as-is, so that we can then call this via (name, args..., "/path/to/script").
There was a problem hiding this comment.
Hmm, this gets a bit weird but we totally can. Should we just temporarily write it then defer a cleanup?
There was a problem hiding this comment.
Agreed, a bit weird, but it'd be awesome to support the use-case fully. I think temp write + cleanup sounds good (and no need to make it executable since we're handling the shebang parsing part)!
This enables much greater portability!