feat: allow storing extra oauth token properties in the database #10152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Oct 9, 2023
Emyrk
reviewed
Oct 9, 2023
Comment on lines
+293
to
+297
| extra := map[string]interface{}{} | ||
| require.NoError(t, json.Unmarshal(updated.OAuthExtra.RawMessage, &extra)) | ||
| mapping, ok := extra["authed_user"].(map[string]interface{}) | ||
| require.True(t, ok) | ||
| require.Equal(t, updated.OAuthAccessToken, mapping["access_token"]) |
There was a problem hiding this comment.
This is 100% ok.
I am thinking of maybe exposing an easy way to hit the IDP with a Bearer token that would essentially do this check. The /userinfo will validate an access token for the request, but oauth2 is a subset of OIDC and does not have an easy UserInfo method to call from the token/config.
Just would be a nice helper to have like fake.UserInfo(accessToken string) or something convenient. Maybe 🤔
Emyrk
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #10151
These will be accessible via the new
external-authcommand in #10052