chore: refactor workspace conversion to accept ownerName #10171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2023
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
f826785 to
44aad4b
Compare
22ca3dc to
048f310
Compare
Base automatically changed from
10-10-chore_drop_unused_redirectToLoginOnMe_parameter
to
main
October 10, 2023 12:13
johnstcn
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors workspace conversion to accept the ownerName, rather than a slice of users, since all it does is search the slice for the owner and use the username.
This is in preparation for a fix to
postWorkspacesByOrganization()that will remove the need to pass the user object.Also avoids panicing if the required user is not in the slice, since
findUsercould return nil in the old code, which would then get dereferenced for the username.