Skip to content

fix: stop leaking User into API handlers unless authorized #10172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

spikecurtis
Copy link
Contributor

Fixes an issue where we extracted the {user} parameter from the URL and added it to the API Handler context regardless of whether the caller had permission to read the User.

@spikecurtis spikecurtis requested review from Emyrk and johnstcn October 10, 2023 12:11
Base automatically changed from 10-10-chore_refactor_conversion_to_accept_ownerName to main October 10, 2023 12:55
@spikecurtis spikecurtis force-pushed the 10-10-use_member_instead_of_user branch from b39a6a9 to 3cabbf6 Compare October 10, 2023 12:57
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate this 👍

@spikecurtis spikecurtis force-pushed the 10-10-use_member_instead_of_user branch from 3cabbf6 to 43e4f42 Compare October 10, 2023 17:47
@spikecurtis spikecurtis merged commit 7c71053 into main Oct 11, 2023
@spikecurtis spikecurtis deleted the 10-10-use_member_instead_of_user branch October 11, 2023 05:41
Copy link
Contributor Author

Merge Activity

@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants