fix(site): fix week range for insights #10173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Oct 10, 2023
mafredri
reviewed
Oct 10, 2023
|
|
||
| export const lastWeeks = (numberOfWeeks: number) => { | ||
| const now = new Date(); | ||
| const startDate = startOfWeek(subWeeks(now, numberOfWeeks)); | ||
| const endDate = isSunday(now) ? endOfDay(now) : endOfWeek(subWeeks(now, 1)); | ||
| const endDate = startOfDay(subDays(now, 1)); |
There was a problem hiding this comment.
Should this perhaps be just startOfDay(now)? Let's say we have now = 2023-10-10T15:00:00 (Tuesday), subDays would put us at 2023-10-09T15:00:00 and startOfDay would give us 2023-10-09T00:00:00 meaning we're only looking at data up to and including Sunday (whereas including Monday would make sense IMO).
There was a problem hiding this comment.
startOfDay does something like 2023-10-09T23:59:59 but the API only accepts dates as "00:00:00" at the end.
There was a problem hiding this comment.
Hmm, I don't understand how startOfDay gives 23:59, I would assume that's endOfDay?
There was a problem hiding this comment.
Ahhh sorry, I missread your comment. I will give it a try
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.