fix(scaletest/dashboard): increase viewport size and handle deadlines #10197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Oct 11, 2023
mafredri
approved these changes
Oct 11, 2023
| @@ -178,6 +192,13 @@ func initChromeDPCtx(ctx context.Context, log slog.Logger, u *url.URL, sessionTo | |||
| } | |||
| } | |||
|
|
|||
| // force a viewport size of 1024x768 so we don't go into mobile mode | |||
| if err := chromedp.Run(cdpCtx, chromedp.EmulateViewport(1024, 768)); err != nil { | |||
There was a problem hiding this comment.
Glad you found this! I totally forgot about the default screen size of headless. 😮💨
6cff4a5 to
b044c4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, turns out that headless chrome has a tiiny viewport by default. Like, 640x480 or something. Small enough to trigger our responsive mobile view. So, I just made the viewport bigger and it fixed things.