Skip to content

chore(site): fix inconsistent fetching results on tests #10215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Oct 11, 2023
@BrunoQuaresma BrunoQuaresma requested review from maeanes, a team and code-asher and removed request for maeanes and a team October 11, 2023 14:08
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy/grateful you caught all these!

@@ -25,24 +25,38 @@ const queryClient = new QueryClient({
},
});

export const AppProviders: FC<PropsWithChildren> = ({ children }) => {
export const ThemeProviders: FC<PropsWithChildren> = ({ children }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the decision to split these up into a separate provider

@BrunoQuaresma BrunoQuaresma merged commit edbd519 into main Oct 11, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-query-client branch October 11, 2023 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants