Skip to content

chore(site): remove create workspace xservice #10217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Oct 11, 2023
Merged

chore(site): remove create workspace xservice #10217

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
10f3c10
Move xstate transitions to provider
BrunoQuaresma Oct 10, 2023
f577c4d
Centrlize auth logic in the provider
BrunoQuaresma Oct 10, 2023
fd84833
Remove actor
BrunoQuaresma Oct 10, 2023
4749547
Remove auth xservice
BrunoQuaresma Oct 10, 2023
6d0e3ab
Add loader while AuthProvider is loading
BrunoQuaresma Oct 10, 2023
06b9748
Simplify and fix a few computed states
BrunoQuaresma Oct 10, 2023
de37d44
Add a few replaces
BrunoQuaresma Oct 10, 2023
cc18ecd
Fix logout
BrunoQuaresma Oct 10, 2023
c6bee93
Remove unused import
BrunoQuaresma Oct 10, 2023
4aec6a5
Fix RequireAuth test
BrunoQuaresma Oct 10, 2023
b588271
Fix wait loader
BrunoQuaresma Oct 10, 2023
ed42cbb
Fix tests
BrunoQuaresma Oct 10, 2023
0f7a300
Remove unecessary type
BrunoQuaresma Oct 11, 2023
7f2c605
Rename workspace queries module
BrunoQuaresma Oct 11, 2023
1593068
Remove auto create from workspace xservice
BrunoQuaresma Oct 11, 2023
902b4b1
Move external auth into its own hook
BrunoQuaresma Oct 11, 2023
1bcc73e
Remove permissions fetching from templateByName query
BrunoQuaresma Oct 11, 2023
816e596
Remove form load from service
BrunoQuaresma Oct 11, 2023
b1ac086
Remove create workspace service entirely
BrunoQuaresma Oct 11, 2023
7175b69
Merge branch 'main' into bq/refactor-create-workspace
Parkreiner Oct 11, 2023
b2d6db9
refactor: update workspace automation to use useEffectEvent
Parkreiner Oct 11, 2023
b548155
Merge branch 'main' into bq/refactor-create-workspace
Parkreiner Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove actor
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Oct 10, 2023
commit fd84833db8a655f143570230215d2a3c4e4190ba
13 changes: 3 additions & 10 deletions site/src/components/AuthProvider/AuthProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useActor, useInterpret } from "@xstate/react";
import { useMachine } from "@xstate/react";
import {
AuthMethods,
UpdateUserProfileRequest,
Expand All @@ -16,7 +16,6 @@ import {
authMachine,
isAuthenticated,
} from "xServices/auth/authXService";
import { ActorRefFrom } from "xstate";

type AuthContextValue = {
isSignedOut: boolean;
Expand All @@ -34,14 +33,12 @@ type AuthContextValue = {
signOut: () => void;
signIn: (email: string, password: string) => void;
updateProfile: (data: UpdateUserProfileRequest) => void;
authService: ActorRefFrom<typeof authMachine>;
};

const AuthContext = createContext<AuthContextValue | undefined>(undefined);

export const AuthProvider: FC<PropsWithChildren> = ({ children }) => {
const authService = useInterpret(authMachine);
const [authState, authSend] = useActor(authService);
const [authState, authSend] = useMachine(authMachine);

const isSignedOut = authState.matches("signedOut");
const isSigningOut = authState.matches("signingOut");
Expand Down Expand Up @@ -83,7 +80,6 @@ export const AuthProvider: FC<PropsWithChildren> = ({ children }) => {
isSignedIn,
isSigningIn,
isUpdatingProfile,
authService,
signOut,
signIn,
updateProfile,
Expand Down Expand Up @@ -112,8 +108,5 @@ export const useAuth = () => {
throw new Error("useAuth should be used inside of <AuthProvider />");
}

return {
...context,
actor: useActor(context.authService),
};
return context;
};