Skip to content

chore(pty/ptytest): add sync.Once to close #10220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

chore(pty/ptytest): add sync.Once to close #10220

merged 1 commit into from
Oct 11, 2023

Conversation

johnstcn
Copy link
Member

If you close a *ptytest.PTY more than once you get spam like this:

    ptytest.go:39: 2023-10-11 15:18:25.893: cmd: PTY: Close failed: pty: closed
    ptytest.go:95: 2023-10-11 15:18:25.893: cmd: closing expecter: PTY close                                                                                      
    ptytest.go:86: 2023-10-11 15:18:25.893: cmd: closing logw                                                                                                     
    ptytest.go:88: 2023-10-11 15:18:25.893: cmd: closed logw: <nil>
    ptytest.go:86: 2023-10-11 15:18:25.893: cmd: closing logr                                                                                                     
    ptytest.go:88: 2023-10-11 15:18:25.893: cmd: closed logr: <nil>                                                                                               
    ptytest.go:112: 2023-10-11 15:18:25.893: cmd: closed expecter

@johnstcn johnstcn self-assigned this Oct 11, 2023
@johnstcn johnstcn merged commit 98a076f into main Oct 11, 2023
@johnstcn johnstcn deleted the cj/ptytest/closeOnce branch October 11, 2023 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri