feat(coderd): add support for sending batched agent metadata #10223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 11, 2023
155664f to
3c65ed1
Compare
johnstcn
reviewed
Oct 12, 2023
3c65ed1 to
9cb5404
Compare
johnstcn
reviewed
Oct 12, 2023
johnstcn
reviewed
Oct 12, 2023
| // @Success 204 "Success" | ||
| // @Router /workspaceagents/me/metadata/{key} [post] | ||
| // @x-apidocgen {"skip": true} | ||
| func (api *API) workspaceAgentPostMetadataDeprecated(rw http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Would it be worthwhile dropping a WARN log advising operators to restart the workspace?
There was a problem hiding this comment.
Good question. What if it's a workspace that is running something semi-critical and can't be shut down for a week? We'd potentially be spamming WARN every second :/
There was a problem hiding this comment.
Fair point! I figure expecting a workspace to be restarted at least once a release is not unreasonable.
johnstcn
approved these changes
Oct 12, 2023
mtojek
approved these changes
Oct 12, 2023
9cb5404 to
dc89ae8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9782