fix(cli): remove invalid character for kubernetes provider in implicit non-obvious plan #10228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t non-obvious plan
mtojek
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Not blocking
The function prepWorkspaceBuild actually does a terraform plan under the hood.
Do you mean this in create.go or something else:
// Run a dry-run with the given parameters to check correctness
dryRun, err := client.CreateTemplateVersionDryRun(inv.Context(), templateVersion.ID, codersdk.CreateTemplateVersionDryRunRequest{
WorkspaceName: args.NewWorkspaceName,
RichParameterValues: buildParameters,
})| @@ -607,7 +602,7 @@ func (r *RootCmd) scaletestCreateWorkspaces() *clibase.Cmd { | |||
| richParameters, err := prepWorkspaceBuild(inv, client, prepWorkspaceBuildArgs{ | |||
| Action: WorkspaceCreate, | |||
| Template: tpl, | |||
| NewWorkspaceName: "scaletest-%", // TODO: the scaletest runner will pass in a different name here. Does this matter? | |||
| NewWorkspaceName: "scaletest-N", // TODO: the scaletest runner will pass in a different name here. Does this matter? | |||
There was a problem hiding this comment.
I presume that the comment is still valid?
There was a problem hiding this comment.
As we saw, it does appear to matter if NewWorkspaceName ends up not being valid :-)
mafredri
approved these changes
Oct 12, 2023
Yes, correct. I vaguely recall this being necessary for rich parameters to work? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #10132.
When running
exp scaletest create-workspacesagainst a kubernetes cluster:The function
prepWorkspaceBuildactually does aterraform planunder the hood.So in effect I was passing
scaletest-%tokubectl create pod, which the Kuberentes terraform provider really hates, but apparently the kreuzwerker Docker provider is cool with.However, if we need to do a plan to get rich parameters, then the
--no-planparameter forexp scaletest create-workspacesisn't really an option. Or am I misunderstanding?