Skip to content

docs: mention /icons in the template documentation #10230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 11, 2023

Screenshot 2023-10-11 at 4 17 17 PM

Closes #8344

@aslilac aslilac requested review from sreya, Kira-Pilot and bpmct October 11, 2023 22:18
@aslilac aslilac changed the title docs: mention /icons docs: mention /icons in the template documentation Oct 11, 2023
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explain more on how an where we can use icons.

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @matifali's verbiage suggestions are great, but I consider this PR gtg after those changes are applied!

aslilac and others added 3 commits October 12, 2023 11:39
Co-authored-by: Muhammad Atif Ali <atif@coder.com>
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@aslilac aslilac merged commit 5fc9ff2 into main Oct 12, 2023
@aslilac aslilac deleted the mention-icons-in-docs branch October 12, 2023 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document predefined emoji/icon images
3 participants