Skip to content

fix: update create workspace button to recognize template names+display names #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Oct 12, 2023

Closes #10231

With this change, the "Create workspace" button goes through all templates available, listing them by display name, then if that's not available, the template name. The text "[Unnamed]" is only used in the event that neither has a usable value.

Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner changed the title fix: only used 'unnamed' as a last resort for templates fix: update create workspace button to recognize template names and display names Oct 12, 2023
@Parkreiner Parkreiner changed the title fix: update create workspace button to recognize template names and display names fix: update create workspace button to recognize template names+display names Oct 12, 2023
@Parkreiner Parkreiner enabled auto-merge (squash) October 12, 2023 00:21
@Parkreiner Parkreiner merged commit 9bf3b35 into main Oct 12, 2023
@Parkreiner Parkreiner deleted the mes/create-button-fix branch October 12, 2023 00:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create workspace dropdown returns Unnamed for templates with no display name
1 participant