feat(scaletest): annotate scaletest pod when scaletest is in progress #10235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Oct 12, 2023
johnstcn
commented
Oct 12, 2023
| @@ -40,7 +40,7 @@ show_json() { | |||
| set_status() { | |||
| dry_run= | |||
| if [[ ${DRY_RUN} == 1 ]]; then | |||
| dry_run=" (dry-ryn)" | |||
| dry_run=" (dry-run)" | |||
|
I gave this a tyre-kicking and nothing exploded, so I think this is good to go! |
mafredri
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7777
This PR modifies the scaletest-runner template to add a pod annotation to the scaletest runner pod.
The annotation key is set to
com.coder.scaletest.phaseand the annotation value is one ofpreparing,running, orcompleted.This will allow checking if a scaletest is in progress, and preventing any operations that would interrupt a running scaletest.