Skip to content

feat: add template setting to require active template version #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Oct 18, 2023
Merged

feat: add template setting to require active template version #10277

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
eb5cb38
add migration
sreya Oct 11, 2023
f31b2fd
add template update plumbing
sreya Oct 11, 2023
3f6dabf
update autobuild
sreya Oct 11, 2023
d9bbfea
add tests for autobuild
sreya Oct 13, 2023
4b3194d
add more tests
sreya Oct 14, 2023
47da214
require_promoted_version -> require_active_version
sreya Oct 15, 2023
92594dc
make gen
sreya Oct 15, 2023
7abc92b
make gen
sreya Oct 15, 2023
402b342
errant copy pasta
sreya Oct 15, 2023
508a84d
rebase
sreya Oct 15, 2023
193388c
space vs tabs
sreya Oct 15, 2023
3750bda
tests and gen
sreya Oct 15, 2023
306d63e
fix things
sreya Oct 15, 2023
f0c932a
fix query
sreya Oct 15, 2023
896320c
fix it for real
sreya Oct 16, 2023
8315933
remove todo
sreya Oct 16, 2023
8e12b66
different ctx
sreya Oct 16, 2023
6a34bc3
pr comments
sreya Oct 17, 2023
d1a9e43
Merge branch 'main' into jon/templateversion
sreya Oct 17, 2023
da82c79
fix a bug
sreya Oct 17, 2023
8853b95
make gen
sreya Oct 17, 2023
6ec940c
add access control implementation
sreya Oct 18, 2023
cd50482
fix some tests
sreya Oct 18, 2023
9ee6898
make gen
sreya Oct 18, 2023
ef112de
move enterprise access control impl into own pkg
sreya Oct 18, 2023
8a4e0bf
pass atomic pointer to autobuild
sreya Oct 18, 2023
693d3a6
make fmt
sreya Oct 18, 2023
3f4ec2e
hm
sreya Oct 18, 2023
9e00957
nits
sreya Oct 18, 2023
e8ec4bb
Merge branch 'main' into jon/templateversion
sreya Oct 18, 2023
a497b71
fix duplicate import error
sreya Oct 18, 2023
f336ab1
unnest test
sreya Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
errant copy pasta
  • Loading branch information
@sreya
sreya committed Oct 15, 2023
commit 402b34260ad5f8bdb6edddd352a8778a5eb9cf3b
2 changes: 0 additions & 2 deletions enterprise/coderd/workspaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,6 @@ func TestWorkspaceAutobuild(t *testing.T) {
ws := coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID)
coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, ws.LatestBuild.ID)

coderdtest.MustTransitionWorkspace(t, client, ws.ID, database.WorkspaceTransitionStart, database.WorkspaceTransitionStop)

// Create a new version that will fail when we try to delete a workspace.
version = coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, &echo.Responses{
Parse: echo.ParseComplete,
Expand Down