-
Notifications
You must be signed in to change notification settings - Fork 887
feat: add user groups column to users table #10284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
cb51aa8
refactor: extract UserRoleCell into separate component
Parkreiner a33fe0c
wip: add placeholder Groups column
Parkreiner cfd1807
fix: remove redundant css styles
Parkreiner d278c20
refactor: update EditRolesButton to use Sets to detect selections
Parkreiner 2fdbd65
wip: commit progress for updated roles column
Parkreiner 0c9525e
wip: commit current role pill progress
Parkreiner 2e2bf08
fix: update state sync logic
Parkreiner b8a73f5
Merge branch 'main' into mes/table-user-groups
Parkreiner 52cb1bf
chore: add groupsByUserId query options factory
Parkreiner df9b25c
fix: update return value of select function
Parkreiner a29f395
chore: drill groups data down to cell component
Parkreiner fd8dafc
wip: commit current cell progress
Parkreiner 3b11414
fix: remove redundant classes
Parkreiner 083bb16
wip: commit current styling progress
Parkreiner 0061dc0
fix: update line height for CTA
Parkreiner 25767c6
fix: update spacing
Parkreiner c2aea9b
chore: add tooltip for Groups column header
Parkreiner 534cf82
fix: remove tsbuild file
Parkreiner f8d8de5
refactor: consolidate tooltip components
Parkreiner 3ec6823
fix: update font size defaults inside theme
Parkreiner 85d4de0
fix: expand hoverable/clickable area of groups cell
Parkreiner 376d20c
fix: remove possible undefined cases from HelpTooltip
Parkreiner b9d2b72
chore: add popover functionality to groups
Parkreiner dc2fedd
wip: commit progress on groups tooltip
Parkreiner 1624981
fix: remove zero-height group name visual bug
Parkreiner 81f252b
feat: get basic version of user group tooltips done
Parkreiner 6cc07b4
perf: move sort order callback outside loop
Parkreiner f73ba71
fix: update spacing for tooltip
Parkreiner c646d9f
feat: make popovers entirely hover-based
Parkreiner c46b42a
fix: disable scroll locking for popover
Parkreiner 3b36858
docs: add comments explaining some pitfalls with Popover component
Parkreiner 49570b0
refactor: simplify userRoleCell implementation
Parkreiner d18641e
feat: complete main feature
Parkreiner 40846c6
fix: prevent scroll lock for role tooltips
Parkreiner c678223
fix: change import to type import
Parkreiner c642ef8
refactor: simplify how groups are clustered
Parkreiner 774e4d5
Merge branch 'main' into mes/table-user-groups
Parkreiner d2cc9cc
refactor: update UserRoleCell to use Popover
Parkreiner 33af1ce
refactor: remove unnecessary fragment
Parkreiner ccb213f
chore: add id/aria support for Popover
Parkreiner 88eaf4a
refactor: update UserGroupsCell to use Popover
Parkreiner 271b704
chore: redo visual design for UserGroupsCell
Parkreiner 8cf2324
fix: shrink UserGroupsCell text
Parkreiner 2e4ce81
fix: update UsersTable test to include groups info
Parkreiner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: update return value of select function
- Loading branch information
commit df9b25c8469fc892d78b6f168250c636bdae43ee
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use lodash so maybe it can be helpful to simplify some of these logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've never used Lodash before, so to be honest, I keep forgetting that we have it, but I'll see if some of their utilities can help out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried going through the documentation, but it didn't seem like Lodash has support for Map objects, and I didn't want to "downgrade" the type by turning it into a regular JS object (which would mean losing better memory usage, easy iteration, and easy size checking)
I did refactor the code to consolidate some loops, though