Skip to content

fix(site): display empty component when workspace has no parameters #10286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(site): display empty component when workspace has no parameters #10286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...c/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,13 @@ type Story = StoryObj<typeof WorkspaceParametersPageView>;

const Example: Story = {};

export const Empty: Story = {
args: {
data: {
buildParameters: [],
templateVersionRichParameters: [],
},
},
};

export { Example as WorkspaceParametersPage };
42 changes: 34 additions & 8 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ import { FC } from "react";
import { isApiValidationError } from "api/errors";
import { ErrorAlert } from "components/Alert/ErrorAlert";
import { WorkspaceBuildParameter } from "api/typesGenerated";
import { EmptyState } from "components/EmptyState/EmptyState";
import Button from "@mui/material/Button";
import OpenInNewOutlined from "@mui/icons-material/OpenInNewOutlined";
import { docs } from "utils/docs";

const WorkspaceParametersPage = () => {
const workspace = useWorkspaceSettings();
Expand Down Expand Up @@ -88,14 +92,36 @@ export const WorkspaceParametersPageView: FC<
)}

{data ? (
<WorkspaceParametersForm
buildParameters={data.buildParameters}
templateVersionRichParameters={data.templateVersionRichParameters}
error={submitError}
isSubmitting={isSubmitting}
onSubmit={onSubmit}
onCancel={onCancel}
/>
data.templateVersionRichParameters.length > 0 ? (
<WorkspaceParametersForm
buildParameters={data.buildParameters}
templateVersionRichParameters={data.templateVersionRichParameters}
error={submitError}
isSubmitting={isSubmitting}
onSubmit={onSubmit}
onCancel={onCancel}
/>
) : (
<EmptyState
message="This workspace has no parameters"
cta={
<Button
component="a"
href={docs("/templates/parameters")}
startIcon={<OpenInNewOutlined />}
variant="contained"
target="_blank"
rel="noreferrer"
>
Learn more about parameters
</Button>
}
css={(theme) => ({
border: `1px solid ${theme.palette.divider}`,
borderRadius: theme.shape.borderRadius,
})}
/>
)
) : (
<Loader />
)}
Expand Down