feat(scaletest/templates): run all scenarios even on failure #10290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also end all failed phases and add the `error` tag in Grafana.
johnstcn
approved these changes
Oct 16, 2023
Comment on lines
+66
to
+74
| # Debug scenarios, for testing the runner. | ||
| "debug:success") | ||
| maybedryrun "$DRY_RUN" sleep 10 | ||
| status=0 | ||
| ;; | ||
| "debug:error") | ||
| maybedryrun "$DRY_RUN" sleep 10 | ||
| status=1 | ||
| ;; |
There was a problem hiding this comment.
_
_ __ (_) ___ ___
| '_ \| |/ __/ _ \
| | | | | (_| __/
|_| |_|_|\___\___|
|
|
||
| wait_baseline "${SCALETEST_PARAM_LOAD_SCENARIO_BASELINE_DURATION}" | ||
| done | ||
|
|
||
| if ((${#failed} > 0)); then | ||
| log "Load scenarios failed: ${!failed[*]}" | ||
| for scenario in "${!failed[@]}"; do |
There was a problem hiding this comment.
I didn't know you could do this :o
There was a problem hiding this comment.
Yup, it's the syntax for accessing associative array keys. 💪🏻 (I much prefer the Zsh way though for scenario in ${(k)failed} or even for scenario code in ${(kv)failed}. 😜)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also end all failed phases and add the
errortag in Grafana.