Skip to content

chore: update semantic types #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2022
Merged

chore: update semantic types #1030

merged 5 commits into from
Apr 15, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Apr 15, 2022 •
edited
Loading

Summary:

PRs like #1025 feel like they deserve an example: type, but we didn't have one.
Furthermore our definitions for correct, fix, and hotfix were stale.

@greyscaled
chore: update semantic types
4fce547 
Summary:

PRs like #1025 feel like they deserve a doc: type, but we didn't have one.
Furthermore our definitions for correct and fix were stale.
greyscaled
greyscaled commented Apr 15, 2022
View reviewed changes
@greyscaled greyscaled self-assigned this Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #1030 (a342411) into main (88e30be) will increase coverage by 9.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1030      +/-   ##
==========================================
+ Coverage   57.70%   67.37%   +9.66%     
==========================================
  Files         259      259              
  Lines       15059    15059              
  Branches      151      151              
==========================================
+ Hits         8690    10146    +1456     
+ Misses       5426     3893    -1533     
- Partials      943     1020      +77
Flag Coverage Δ
unittest-go-macos-latest 53.56% <ø> (+0.09%) ⬆️
unittest-go-postgres- 66.62% <ø> (?)
unittest-go-ubuntu-latest 56.29% <ø> (-0.02%) ⬇️
unittest-go-windows-2022 53.03% <ø> (+0.04%) ⬆️
unittest-js 68.20% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/listen.go 84.16% <0.00%> (-3.34%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
peer/conn.go 79.69% <0.00%> (-0.26%) ⬇️
peer/channel.go 83.81% <0.00%> (+0.57%) ⬆️
coderd/workspaceagents.go 59.82% <0.00%> (+1.33%) ⬆️
coderd/templates.go 62.29% <0.00%> (+1.63%) ⬆️
cli/cliui/provisionerjob.go 78.57% <0.00%> (+2.14%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
provisionerd/provisionerd.go 80.73% <0.00%> (+2.64%) ⬆️
coderd/provisionerdaemons.go 63.46% <0.00%> (+4.11%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e30be...a342411. Read the comment docs.

kylecarbs
kylecarbs reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we make an example tag for now. It'd be cool to see the delta of example changes between releases anyways!

@greyscaled
Copy link
Contributor Author

I'd prefer we make an example tag for now. It'd be cool to see the delta of example changes between releases anyways!

sounds great to me!

greyscaled
greyscaled commented Apr 15, 2022
View reviewed changes
greyscaled
greyscaled commented Apr 15, 2022
View reviewed changes
@greyscaled greyscaled requested review from kylecarbs, a team, deansheather, Emyrk, f0ssel, johnstcn and coadler and removed request for johnstcn, Emyrk, coadler, deansheather and f0ssel April 15, 2022 18:48
kylecarbs
kylecarbs approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

greyscaled
greyscaled commented Apr 15, 2022
View reviewed changes
@greyscaled greyscaled merged commit 148e7cd into main Apr 15, 2022
@greyscaled greyscaled deleted the vapurrmaid/semantic-types branch April 15, 2022 20:26
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@johnstcn johnstcn johnstcn approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@greyscaled greyscaled

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
5 participants
@greyscaled @presleyp @johnstcn @kylecarbs @misskniss