Skip to content

fix(scaletest/templates): fix bugs and improve debugging #10316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix(scaletest/templates): fix bugs and improve debugging #10316

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a4597f
fix(scaletest/templates): fix bugs and improve debugging
mafredri Oct 17, 2023
a4f12a6
make sure we echo the exit code
mafredri Oct 17, 2023
f7ec175
fix script exit before subprocesses
mafredri Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix script exit before subprocesses
  • Loading branch information
@mafredri
mafredri committed Oct 17, 2023
commit f7ec1758a3d32a53c4efb3f6f6c286df2efb7ae4
7 changes: 6 additions & 1 deletion scaletest/templates/scaletest-runner/startup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ annotate_grafana "workspace" "Agent running" # Ended in shutdown.sh.
trap 'trap - EXIT; kill -INT "${pids[@]}"; exit 1' INT EXIT

while :; do
sleep 285 # ~300 when accounting for profile and trace.
# Sleep for short periods of time so that we can exit quickly.
# This adds up to ~300 when accounting for profile and trace.
for ((i = 0; i < 285; i++)); do
sleep 1
done
log "Grabbing pprof dumps"
start="$(date +%s)"
annotate_grafana "pprof" "Grab pprof dumps (start=${start})"
Expand Down Expand Up @@ -132,6 +136,7 @@ on_exit() {

annotate_grafana_end "" "Start scaletest: ${SCALETEST_COMMENT}"

wait "${pprof_pid}"
exit "${code}"
}
trap on_exit EXIT
Expand Down