feat: expose template insights as Prometheus metrics #10325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2023
johnstcn
approved these changes
Oct 18, 2023
Comment on lines
96
to
106
| templateNames := map[uuid.UUID]string{} | ||
| if len(templateIDs) > 0 { | ||
| templates, err := mc.database.GetTemplatesWithFilter(ctx, database.GetTemplatesWithFilterParams{ | ||
| IDs: templateIDs, | ||
| }) | ||
| if err != nil { | ||
| mc.logger.Error(ctx, "unable to fetch template details from database", slog.Error(err)) | ||
| return | ||
| } | ||
| templateNames = onlyTemplateNames(templates) | ||
| } |
There was a problem hiding this comment.
non-blocking, potential improvement: cache template ID -> template name to avoid DB fetches
There was a problem hiding this comment.
Thanks for your suggestion. Honestly, I wouldn't cache it yet unless we face performance issues. We would have to define the cache expiry and call db when templates are gone. Loop iterations are scheduled every 5 minutes by default, so I hope it won't impact performance. For sure, insights calls are heavier.
There was a problem hiding this comment.
Agreed, just something to think about later!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #9983
part 1/3 - I decided to split this PR into 3 parts to simplify code reviews. Unfortunately, we need to implement 3 extra DB queries with matching
dbfakeimplementation.This PR exposes "active users" metric from Coder template insights.