Skip to content

fix: show dormant and suspended users in groups #10333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

Kira-Pilot
Copy link
Member

resolves #10267

I am also showing suspended users because I am not sure why we wouldn't want to. Let me know if this is a misstep and I'll revert it.
Screenshot 2023-10-18 at 3 05 22 PM

@BrunoQuaresma
Copy link
Collaborator

I think could be interesting to add a column "status" as we have on the users' page.

@sreya
Copy link
Collaborator

sreya commented Oct 18, 2023

I'm of the opinion that we should do the opposite: we shouldn't allow adding dormant or suspended users to groups. Thoughts?

@BrunoQuaresma
Copy link
Collaborator

@sreya I think it is ok but we still have to deal with the case where users can be added to the group and be set as dormant or suspended after.

@Kira-Pilot
Copy link
Member Author

@sreya @BrunoQuaresma If we didn't allow adding them to groups, we'd have to figure out what to do with users who have been previously added to groups and then become dormant or suspended, which, IMO, may unnecessarily complicate things. Do we have a good reason to not want them added? I can add a status column to make their inactive status more apparent as per Bruno's suggestion if that makes their presence more tolerable.

@sreya
Copy link
Collaborator

sreya commented Oct 18, 2023

Yeah I guess I was thinking we just wouldn't return suspended or dormant users. Dormant users don't count against the license count so it's almost like they don't "exist". But I'm fine with Bruno's suggestion of labeling them if they aren't active.

@Kira-Pilot
Copy link
Member Author

@sreya sounds good. I could even see someone wanting to make a group of all dormant users for licensing purposes.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes look good to me!

@Kira-Pilot Kira-Pilot merged commit ed5567b into main Oct 20, 2023
@Kira-Pilot Kira-Pilot deleted the dormant-users-groups/kira-pilot branch October 20, 2023 15:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: If a user is dormant, the Group UI will not show them in the list view.
3 participants