Skip to content

feat: add frontend support for mandating active template version #10338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Oct 19, 2023

This PR adds the frontend for configuring the "Require Active Template" button. It also modifies the user's available actions in the workspace page dependent on whether they possess template write privileges.

Template Form:

Screenshot 2023-10-18 at 8 36 41 PM

Regular User Workspace Page (Stopped):

Screenshot 2023-10-18 at 8 37 42 PM

Regular User Workspace Page (Started):

Screenshot 2023-10-18 at 8 39 25 PM

fixes #7467

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE code looks ok. I just would add a storybook for when the Workspace has this setting enabled so we can avoid regressions.

@sreya sreya force-pushed the jon/activeversionfe branch from b81e75e to 128c27f Compare October 19, 2023 22:17
@sreya sreya merged commit d335261 into main Oct 19, 2023
@sreya sreya deleted the jon/activeversionfe branch October 19, 2023 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
@matifali
Copy link
Member

Hi @sreya, do we need to enable it specifically to show in the dashboard UI? I can not see this option on the build: d335261.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow enabling / disabling template version selection on the front end
3 participants