feat(cli): prompt for misspelled parameter names #10350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a162f63 to
6ab0407
Compare
mafredri
approved these changes
Oct 27, 2023
| return int(d[i+1][j+1]), ErrMaxDist | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Not against us having our own implementation, but there's also: https://github.com/agnivade/levenshtein (in this case, the performance optimizations are negligible, though.)
There was a problem hiding this comment.
I was also considering https://pkg.go.dev/github.com/junegunn/fzf@v0.0.0-20231029150554-1cfa3ee4c7c1/src/algo but didn't want to necessarily add a dep just for this.
| Needle: "foo", | ||
| MaxDistance: 2, | ||
| Haystack: []string{"bar", "boo", "boof"}, | ||
| Expected: []string{"boo", "boof"}, |
There was a problem hiding this comment.
Should we test some slightly longer inputs as well?
6ab0407 to
24a04fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10292
Performs a fuzzy-matching based on Levenshtein edit distance when an unknown parameter name is encountered.
Edit distance defaults to
len(parameter)/2.Should result in less guessing about what that parameter was named exactly.