Skip to content

docs: fix additional cluster SA, role names #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023
Merged

docs: fix additional cluster SA, role names #10366

merged 1 commit into from
Oct 20, 2023

Conversation

ericpaulsen
Copy link
Member

this PR changes the names of the SA, role and role binding created as a part of our Additional Clusters documentation. the name was previously coder, which caused duplicate-related errors due to the control plane RBAC resources having the same name.

@ericpaulsen ericpaulsen added docs Area: coder.com/docs bug labels Oct 20, 2023
@ericpaulsen ericpaulsen requested review from matifali and bpmct October 20, 2023 15:23
@ericpaulsen ericpaulsen self-assigned this Oct 20, 2023
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tested, good to merge.

@ericpaulsen ericpaulsen changed the title fix: additional cluster SA, role names docs: fix additional cluster SA, role names Oct 20, 2023
@ericpaulsen ericpaulsen merged commit 9dbc913 into main Oct 20, 2023
@ericpaulsen ericpaulsen deleted the sa-name branch October 20, 2023 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants