Skip to content

test(agent): improve TestAgent_Session_TTY_MOTD_Update #10385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2023
Merged

test(agent): improve TestAgent_Session_TTY_MOTD_Update #10385

merged 3 commits into from
Oct 23, 2023

Conversation

mafredri
Copy link
Member

This may help reduce flakes as observed in #10143

We let the tests share the same SSH client and each SSH session is torn down after the test (previously all were left open until the end).

@mafredri mafredri self-assigned this Oct 23, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Oct 23, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mafredri mafredri mentioned this pull request Oct 23, 2023
Closed
@mafredri mafredri enabled auto-merge (squash) October 23, 2023 17:05
@mafredri mafredri merged commit 1286904 into main Oct 23, 2023
@mafredri mafredri deleted the mafredri/test-agent-improve-tty-motd-update branch October 23, 2023 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mafredri