Skip to content

feat(cli): support header and header-command in config-ssh #10413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 7, 2024
Merged

feat(cli): support header and header-command in config-ssh #10413

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
42a7512
feat(configssh): add any provided header command to the SSH config also
JoshVee Oct 19, 2023
9a9ff38
chore: escape command also
JoshVee Oct 19, 2023
57355fb
Merge branch 'main' into joshvee-ssh-header-command
JoshVee Oct 19, 2023
1220039
chore: fix up the variable name
JoshVee Oct 19, 2023
a785392
chore: more test cases
JoshVee Oct 19, 2023
c5e0ec1
chore: fix tests
JoshVee Oct 19, 2023
7fc1849
Merge branch 'coder:main' into joshvee-ssh-header-command
JoshVee Oct 30, 2023
ed5e82b
Merge branch 'main' into joshvee-ssh-header-command
mafredri Feb 5, 2024
1c585c4
remove echoResponses
mafredri Feb 5, 2024
bcdb129
add support for serializing header and header-command
mafredri Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix tests
  • Loading branch information
@JoshVee
JoshVee committed Oct 19, 2023
commit c5e0ec15a34e860160f6bf28a75a207448eeea23
21 changes: 12 additions & 9 deletions cli/configssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,43 +588,46 @@ func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) {
{
name: "Header command",
args: []string{
"--header-command", "/foo/bar/coder",
"--yes",
"--header-command", "printf h1=v1",
},
wantErr: false,
echoResponse: &echo.Responses{
Parse: echo.ParseComplete,
ProvisionApply: echo.ProvisionApplyWithAgent(""),
},
wantErr: false,
wantConfig: wantConfig{
regexMatch: "--header-command \"/foo/bar/coder\" ssh",
regexMatch: "--header-command \"printf h1=v1\" ssh",
},
},
{
name: "Header command with double quotes",
args: []string{
"--header-command", "/foo/bar/coder arg1 arg2=\"quoted value\"",
"--yes",
"--header-command", "printf h1=v1 h2=\"v2\"",
},
wantErr: false,
echoResponse: &echo.Responses{
Parse: echo.ParseComplete,
ProvisionApply: echo.ProvisionApplyWithAgent(""),
},
wantErr: false,
wantConfig: wantConfig{
regexMatch: "--header-command \"/foo/bar/coder arg1 arg2=\\\"quoted value\\\"\" ssh",
regexMatch: "--header-command \"printf h1=v1 h2=\\\\\"v2\\\\\"\" ssh",
},
},
{
name: "Header command with single quotes",
args: []string{
"--header-command", "/foo/bar/coder arg1 arg2='quoted value'",
"--yes",
"--header-command", "printf h1=v1 h2='v2'",
},
wantErr: false,
echoResponse: &echo.Responses{
Parse: echo.ParseComplete,
ProvisionApply: echo.ProvisionApplyWithAgent(""),
},
wantErr: false,
wantConfig: wantConfig{
regexMatch: "--header-command \"/foo/bar/coder arg1 arg2='quoted value'\" ssh",
regexMatch: "--header-command \"printf h1=v1 h2='v2'\" ssh",
},
},
}
Expand Down