feat: add dbfake for workspace builds and resources #10426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0913ae1 to
a6fe665
Compare
This creates `coderdtest.NewWithDatabase` and adds a series of helper functions to `dbfake` that insert structured fake data for resources into the database. It allows us to remove provisionerd from a significant amount of tests which should speed them up and reduce flakes.
Emyrk
reviewed
Oct 30, 2023
Emyrk
reviewed
Oct 30, 2023
Emyrk
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Last comment, can merge without. Maybe we should not name this CreateWorkspace, because we use that exact wording in our API related helpers which actually goes through the Create flow and has all the deps correct.
Maybe name it InsertWorkspace? PutWorkspace? Some other word?
mafredri
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Nice work, I think this is a huge improvement for writing tests!
I did notice CI is still quite unhappy:
- pq: insert or update on table "workspace_builds" violates foreign key constraint "workspace_builds_job_id_fkey"
Perhaps just a case of missing ID in a call to dbgen (in dbfake).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates
coderdtest.NewWithDatabaseand adds a series of helper functions todbfakethat insert structured fake data for resources into the database.It allows us to remove provisionerd from many tests, which should speed them up and reduce flakes.
Ideally, we merge this then I convert all tests to use this new structure. It's intentionally abstract right now because I assume more patterns will emerge as I work through cases.