Skip to content

chore: use emotion for styling (pt. 8) #10447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 1, 2023
Merged

chore: use emotion for styling (pt. 8) #10447

merged 23 commits into from
Nov 1, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 31, 2023

Part of #9924
Following #10431

Progress 85_9

From starting with 157 usages of makeStyles across 154 files, this changes brings us down to 22 usages across as many files.

Getting much closer! This is probably the second to last PR.

@aslilac aslilac force-pushed the emotional-damage-8 branch from 2a9abe4 to d84bf88 Compare October 31, 2023 21:29
@aslilac aslilac requested review from a team and Parkreiner and removed request for a team November 1, 2023 16:36
@aslilac aslilac marked this pull request as ready for review November 1, 2023 16:37
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I do have a couple of questions about "Emotion best practices" (just to make sure I'm doing things right in my own code), but those can wait until tomorrow's FE variety

@aslilac
Copy link
Member Author

aslilac commented Nov 1, 2023

I'll try to prep some material for that tomorrow!

@aslilac aslilac merged commit 7f70a23 into main Nov 1, 2023
@aslilac aslilac deleted the emotional-damage-8 branch November 1, 2023 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@aslilac aslilac linked an issue Nov 1, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace makeStyles
2 participants