ci: Don't run internal steps if forked #1045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Apr 15, 2022
.github/workflows/coder.yaml
Outdated
| @@ -184,7 +184,7 @@ jobs: | |||
| -timeout=3m -count=$GOCOUNT -short -failfast | |||
|
|
|||
| - name: Upload DataDog Trace | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' && github.repository_owner == 'coder' | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork | |||
There was a problem hiding this comment.
Would it be better to check if the secret is empty?
There was a problem hiding this comment.
Apparently you can't... actions/runner#520
There was a problem hiding this comment.
Well, you can. It's just janky.
Codecov Report
@@ Coverage Diff @@
## main #1045 +/- ##
===========================================
- Coverage 67.48% 56.26% -11.23%
===========================================
Files 259 133 -126
Lines 15059 13464 -1595
Branches 151 0 -151
===========================================
- Hits 10162 7575 -2587
- Misses 3881 5006 +1125
+ Partials 1016 883 -133
Continue to review full report at Codecov.
|
coadler
reviewed
Apr 15, 2022
.github/workflows/coder.yaml
Outdated
| @@ -184,7 +184,7 @@ jobs: | |||
| -timeout=3m -count=$GOCOUNT -short -failfast | |||
|
|
|||
| - name: Upload DataDog Trace | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' && github.repository_owner == 'coder' | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork | |||
There was a problem hiding this comment.
Also random thought, (success() || failure()) can just be always()
There was a problem hiding this comment.
Good point. Will change
This was causing CI to fail for contributions.
a5fa55e to
5065c4e
Compare
|
Did you mean to merge this? |
|
Nah nah I opened this as a fork instead just to confirm it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing CI to fail for contributions.