feat(cli/vscodessh): add support for --wait and scripts that block login #10473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kylecarbs thoughts? Should we take this approach or implement this in the VS Code extension instead? Here's a picture after clicking 
|
|
@mafredri - i'm reopening this, as another customer has inquired about this missing functionality. |
39aec7a to
9080cd9
Compare
johnstcn
approved these changes
Jan 3, 2024
|
Once coder/vscode-coder#194 is merged/released, we can merge this as well. Before that there's a high chance enabling this will lead to a worse user experience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a quick stab at adding support for
--wait=auto|yes|notocoder vscodessh. This allows the VS Code extension to block login until the blocking startup scripts are ready.Implementing it this way has two down-sides, though:
Remote - SSHextensionsConnection Timeoutsetting needs to be raised (from the default15s, I set mine to300s)detailsto see what's going on (this can be seen as a pro, too)An alternative approach would be to stream the logs directly in the Coder VS Code extension, at the risk of maintining two different code paths in two separate projects.