fix(agent): add tracking for JetBrains Gateway and Fleet #10491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
approved these changes
Nov 2, 2023
| @@ -1,6 +1,5 @@ | |||
| [default.extend-identifiers] | |||
| alog = "alog" | |||
| Jetbrains = "JetBrains" | |||
There was a problem hiding this comment.
I had to remove this to fix the lint check. Otherwise, typos CLI complains about
https://github.com/coder/coder/pull/10491/files#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396R268
There is no way to skip checking a single line.
The best we can do is skip the whole file.
There was a problem hiding this comment.
Ah, I see. And this is a github linter, no golang-ci lint. That you could skip one line.
|
This does not work. We only check for env variables when the initial connection is est blished, ut the variables I am looking for are being injected later when we select the IDE and connect via it and possibly when we open the integrated terminal. I am closing it for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is more of a workaround than a fix. It fixes an issue where a session's
MagicTypewas not correctly identified when connecting to a workspace via JetBrains Gateway or Fleet. As a result, the session was not being tracked in the agent's stats. To identify them correctly, this PR adds a check for theTERMINAL_EMULATORandTERM_PROGRAMenvironment variables. The current approach does not segregate between Fleet and Gateway usage and consolidates both underMagicSessionTypeJetBrains.Fixes #9673.
Testing
I am trying to test it via a PR deployment.
Future work
For the future, we can separate tracking Gleet and Gateway usage.