Skip to content

refactor(site): minor improvements on users page popovers #10492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023
+26 −4
Merged

refactor(site): minor improvements on users page popovers #10492

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfda7a7
refactor(site): minor improvements on users page popovers
BrunoQuaresma Nov 2, 2023
0029eaf
Fix lint
BrunoQuaresma Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion site/src/pages/UsersPage/UsersTable/UserGroupsCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
PopoverTrigger,
PopoverContent,
} from "components/Popover/Popover";
import { css } from "@emotion/css";

type GroupsCellProps = {
userGroups: readonly Group[] | undefined;
Expand Down Expand Up @@ -68,7 +69,23 @@ export function UserGroupsCell({ userGroups }: GroupsCellProps) {
</Button>
</PopoverTrigger>

<PopoverContent disableScrollLock disableRestoreFocus>
<PopoverContent
disableScrollLock
disableRestoreFocus
css={(theme) => ({
".MuiPaper-root": {
minWidth: "auto",
},
})}
anchorOrigin={{
vertical: "top",
horizontal: "center",
}}
transformOrigin={{
vertical: "bottom",
horizontal: "center",
}}
>
<OverflowY maxHeight={400}>
<List
component="ul"
Expand Down
9 changes: 9 additions & 0 deletions site/src/pages/UsersPage/UsersTable/UserRoleCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,17 @@ function OverflowRolePill({ roles }: OverflowRolePillProps) {
rowGap: theme.spacing(1.5),
padding: theme.spacing(1.5, 2),
alignContent: "space-around",
minWidth: "auto",
},
}}
anchorOrigin={{
vertical: -4,
horizontal: "center",
}}
transformOrigin={{
vertical: "bottom",
horizontal: "center",
}}
>
{roles.map((role) => (
<Pill
Expand Down