Skip to content

fix(site): fix health tooltip on deployment bar #10502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix(site): fix health tooltip on deployment bar #10502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,20 +179,20 @@ export const DeploymentBannerView: FC<DeploymentBannerViewProps> = (props) => {
We have detected problems with your Coder deployment.
</HelpTooltipTitle>
<Stack spacing={1}>
{health.access_url && (
{!health.access_url.healthy && (
<HealthIssue>
Your access URL may be configured incorrectly.
</HealthIssue>
)}
{health.database && (
{!health.database.healthy && (
<HealthIssue>Your database is unhealthy.</HealthIssue>
)}
{health.derp && (
{!health.derp.healthy && (
<HealthIssue>
We&apos;re noticing DERP proxy issues.
</HealthIssue>
)}
{health.websocket && (
{!health.websocket.healthy && (
<HealthIssue>
We&apos;re noticing websocket issues.
</HealthIssue>
Expand Down Expand Up @@ -406,8 +406,8 @@ const WorkspaceBuildValue: FC<{

const HealthIssue: FC<PropsWithChildren> = ({ children }) => {
return (
<Stack direction="row" spacing={1}>
<ErrorIcon fontSize="small" htmlColor={colors.red[10]} />
<Stack direction="row" spacing={1} alignItems="center">
<ErrorIcon css={{ width: 16, height: 16 }} htmlColor={colors.red[10]} />
{children}
</Stack>
);
Expand Down
2 changes: 1 addition & 1 deletion site/src/testHelpers/entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2817,7 +2817,7 @@ export const DeploymentHealthUnhealthy: Health = {
healthy: false,
time: "2023-10-12T23:15:00.000000000Z",
coder_version: "v2.3.0-devel+8cca4915a",
access_url: { healthy: false },
access_url: { healthy: true },
database: { healthy: false },
derp: { healthy: false },
websocket: { healthy: false },
Expand Down