Skip to content

feat: add endpoint for resolving autostart status #10507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 9, 2023
Merged

feat: add endpoint for resolving autostart status #10507

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
872e214
feat: add endpoint for resolving workspace autostart
sreya Nov 3, 2023
d23fbed
make gen
sreya Nov 8, 2023
f563e66
make gen
sreya Nov 8, 2023
601d127
rm old code
sreya Nov 8, 2023
6dadff4
swagger
sreya Nov 8, 2023
5ea7c06
update endpoint name
sreya Nov 8, 2023
1e9fede
pr changes
sreya Nov 8, 2023
551cf1a
lint
sreya Nov 8, 2023
ebbe551
wtf
sreya Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pr changes
  • Loading branch information
@sreya
sreya committed Nov 8, 2023
commit 1e9fede5aa10f68ce0a6913eb4fc594b46202cd4
14 changes: 9 additions & 5 deletions coderd/workspaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,8 @@ func (api *API) resolveAutostart(rw http.ResponseWriter, r *http.Request) {
return
}

useActiveVersion := template.RequireActiveVersion || workspace.AutomaticUpdates == database.AutomaticUpdatesAlways
templateAccessControl := (*(api.AccessControlStore.Load())).GetTemplateAccessControl(template)
useActiveVersion := templateAccessControl.RequireActiveVersion || workspace.AutomaticUpdates == database.AutomaticUpdatesAlways
if !useActiveVersion {
httpapi.Write(ctx, rw, http.StatusOK, codersdk.ResolveAutostartResponse{})
return
Expand Down Expand Up @@ -1111,7 +1112,7 @@ func (api *API) resolveAutostart(rw http.ResponseWriter, r *http.Request) {

dbVersionParams, err := api.Database.GetTemplateVersionParameters(ctx, version.ID)
if err != nil {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
Message: "Internal error fetching template version parameters.",
Detail: err.Error(),
})
Expand Down Expand Up @@ -1141,13 +1142,16 @@ func (api *API) resolveAutostart(rw http.ResponseWriter, r *http.Request) {
}

var response codersdk.ResolveAutostartResponse
for i := 0; i < len(versionParams) && !response.ParameterMismatch; i++ {
_, err := resolver.ValidateResolve(versionParams[i], nil)
for _, param := range versionParams {
_, err := resolver.ValidateResolve(param, nil)
// There's a parameter mismatch if we get an error back from the
// resolver.
response.ParameterMismatch = err != nil
}
if response.ParameterMismatch {
break
}

}
httpapi.Write(ctx, rw, http.StatusOK, response)
}

Expand Down