Skip to content

refactor(site): improve templates empty state #10518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 6, 2023
Merged

refactor(site): improve templates empty state #10518

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e3a351e
Redirects to template after setup
BrunoQuaresma Nov 3, 2023
cae37d5
Refactor template example cards and first create template experience
BrunoQuaresma Nov 3, 2023
d8987b9
Minor improvements
BrunoQuaresma Nov 3, 2023
bdb43c6
Fix verbiage
BrunoQuaresma Nov 3, 2023
4109264
Fix test
BrunoQuaresma Nov 3, 2023
935b09b
Fix template display name on card
BrunoQuaresma Nov 3, 2023
250f764
Refactor card layout
BrunoQuaresma Nov 3, 2023
817c01f
Merge branch 'main' of https://github.com/coder/coder into bq/improve…
BrunoQuaresma Nov 6, 2023
6acd193
Move readmore to be inline
BrunoQuaresma Nov 6, 2023
db54495
Merge branch 'main' of https://github.com/coder/coder into bq/improve…
BrunoQuaresma Nov 6, 2023
7453346
Decrease line height
BrunoQuaresma Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor improvements
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Nov 3, 2023
commit d8987b9fe48879397f958c9765ffb944fefff9a9
13 changes: 6 additions & 7 deletions site/src/components/TemplateExampleCard/TemplateExampleCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,16 @@ import Button from "@mui/material/Button";
import Link from "@mui/material/Link";
import type { TemplateExample } from "api/typesGenerated";
import { Pill } from "components/Pill/Pill";
import { type FC } from "react";
import { HTMLProps } from "react";
import { Link as RouterLink } from "react-router-dom";

export interface TemplateExampleCardProps {
type TemplateExampleCardProps = {
example: TemplateExample;
activeTag?: string;
}
} & HTMLProps<HTMLDivElement>;

export const TemplateExampleCard: FC<TemplateExampleCardProps> = ({
example,
activeTag,
}) => {
export const TemplateExampleCard = (props: TemplateExampleCardProps) => {
const { example, activeTag, ...divProps } = props;
return (
<div
css={(theme) => ({
Expand All @@ -27,6 +25,7 @@ export const TemplateExampleCard: FC<TemplateExampleCardProps> = ({
display: "flex",
flexDirection: "column",
})}
{...divProps}
>
<div
css={{
Expand Down
14 changes: 7 additions & 7 deletions site/src/pages/StarterTemplatesPage/StarterTemplatesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,11 @@ export const StarterTemplatesPageView: FC<StarterTemplatesPageViewProps> = ({

{Boolean(!starterTemplatesByTag) && <Loader />}

<Stack direction="row" spacing={4}>
<Stack direction="row" spacing={4} alignItems="flex-start">
{starterTemplatesByTag && tags && (
<Stack css={styles.filter}>
<Stack
css={{ width: 208, flexShrink: 0, position: "sticky", top: 48 }}
>
<span css={styles.filterCaption}>Filter</span>
{tags.map((tag) => (
<Link
Expand Down Expand Up @@ -90,6 +92,9 @@ export const StarterTemplatesPageView: FC<StarterTemplatesPageViewProps> = ({
{visibleTemplates &&
visibleTemplates.map((example) => (
<TemplateExampleCard
css={(theme) => ({
backgroundColor: theme.palette.background.paper,
})}
example={example}
key={example.id}
activeTag={activeTag}
Expand All @@ -102,11 +107,6 @@ export const StarterTemplatesPageView: FC<StarterTemplatesPageViewProps> = ({
};

const styles = {
filter: (theme) => ({
width: theme.spacing(26),
flexShrink: 0,
}),

filterCaption: (theme) => ({
textTransform: "uppercase",
fontWeight: 600,
Expand Down