Skip to content

feat: add list of user's groups to Accounts page #10522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 7, 2023

Conversation

Parkreiner
Copy link
Member

Closes #10425

Changes made

  • Adds AvatarCard component
  • Adds ability to query all groups for a specific user
  • Fixes up some of the accessibility issues around how we've been using image alt text
  • Renders a user's groups to the Accounts page via AvatarCard

Other notes

  • One thing I've noticed is that the base <MUIAvatar> component doesn't work super well with the emoji icons, funnily enough because they're "too" perfectly square. MUI takes the images and sands off the corners via borderRadius, making the icons always look funny
    • Ideally, there'd be a way to detect when we have an emoji icon, and shrink it down so that the image isn't cut up
    • Need to ask if the emoji have a common URL that we could maybe use. Maybe there's a way to sneak that logic into this PR?
    • This issue also affects every single component already using <MUIAvatar>, sadly

@Parkreiner Parkreiner requested review from a team and BrunoQuaresma and removed request for a team November 3, 2023 22:32
@BrunoQuaresma
Copy link
Collaborator

I'm missing a storybook with the form + card usage.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments.

@Parkreiner Parkreiner merged commit f5c4826 into main Nov 7, 2023
@Parkreiner Parkreiner deleted the mes/account-page-user-groups branch November 7, 2023 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let users always see their own groups from the Accounts page
2 participants