Skip to content

chore(scripts/rules.go): broaden scope of testingWithOwnerUser linter #10548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2023
Merged

chore(scripts/rules.go): broaden scope of testingWithOwnerUser linter #10548

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33b744c
chore(scripts/rules.go): broaden scope of testingWithOwnerUser linter
johnstcn Nov 6, 2023
44a9dd6
coderdtest: add UpdateTemplateMeta and CreateGroup test helpers
johnstcn Nov 7, 2023
d46d312
ignore enterprise imports in custom linters
johnstcn Nov 8, 2023
c342498
address new linter complaints
johnstcn Nov 6, 2023
9ea11c2
address comments
johnstcn Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ignore enterprise imports in custom linters
  • Loading branch information
@johnstcn
johnstcn committed Nov 8, 2023
commit d46d3123cc068bb18def0076f989f80228a8be99
1 change: 1 addition & 0 deletions scripts/check_enterprise_imports.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ find . -regex ".*\.go" |
grep -v "./enterprise" |
grep -v ./scripts/auditdocgen/ --include="*.go" |
grep -v ./scripts/clidocgen/ --include="*.go" |
grep -v ./scripts/rules.go |
xargs grep -n "github.com/coder/coder/v2/enterprise"
# reverse the exit code because we want this script to fail if grep finds anything.
status=$?
Expand Down