Skip to content

fix: stop SSHKeysPage from flaking #10553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 7, 2023
Merged

fix: stop SSHKeysPage from flaking #10553

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9bdda94
refactor: reorganize SSHKeysPage
Parkreiner Nov 6, 2023
0e1caf2
refactor: update render behavior for GlobalSnackbar
Parkreiner Nov 6, 2023
bc9b5af
fix: remove redundant error handling
Parkreiner Nov 6, 2023
3f491e1
docs: Clean up wording on docs
Parkreiner Nov 6, 2023
c619d34
fix: remove temp error handling tests
Parkreiner Nov 6, 2023
8083591
fix: remove local error alert
Parkreiner Nov 6, 2023
7dabbe3
fix: remove error logging hacks
Parkreiner Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: remove error logging hacks
  • Loading branch information
@Parkreiner
Parkreiner committed Nov 6, 2023
commit 7dabbe3ca6f961143c7f876ca8ee53e9fe332e41
15 changes: 0 additions & 15 deletions site/src/pages/UserSettingsPage/SSHKeysPage/SSHKeysPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,6 @@ import { renderWithAuth } from "testHelpers/renderHelpers";
import { Language as SSHKeysPageLanguage, SSHKeysPage } from "./SSHKeysPage";
import { MockGitSSHKey, mockApiError } from "testHelpers/entities";

/**
* React Query will automatically log all errors outside of production mode,
* even if you're running a test where they're expected
*
* v4 had a way to set custom loggers, but they're removed in v5. Only other
* option is changing the env directly, which feels super dicey
*/
beforeAll(() => {
jest.spyOn(console, "error").mockImplementation(() => {});
});

afterAll(() => {
jest.clearAllMocks();
});

describe("SSH keys Page", () => {
it("shows the SSH key", async () => {
renderWithAuth(<SSHKeysPage />);
Expand Down