feat(scaletest): add greedy agent test to runner #10559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a3d00a to
45b4f12
Compare
7a8eb52 to
1278cbe
Compare
mafredri
commented
Dec 1, 2023
| @@ -584,7 +630,7 @@ resource "kubernetes_pod" "main" { | |||
| } | |||
| # Set the pod delete timeout to termination_grace_period_seconds + 1m. | |||
| timeouts { | |||
| delete = "${(local.workspace_pod_termination_grace_period_seconds + 120) / 60}s" | |||
| delete = "${(local.workspace_pod_termination_grace_period_seconds + 120)}s" | |||
There was a problem hiding this comment.
Review: bug fix, already in seconds.
219a42a to
11926ce
Compare
johnstcn
approved these changes
Dec 5, 2023
mtojek
approved these changes
Dec 5, 2023
| # Unzip scripts and add to path. | ||
| # shellcheck disable=SC2153 | ||
| echo "Extracting scaletest scripts into ${SCRIPTS_DIR}..." | ||
| base64 -d <<<"${SCRIPTS_ZIP}" >/tmp/scripts.zip | ||
| rm -rf "${SCRIPTS_DIR}" || true | ||
| mkdir -p "${SCRIPTS_DIR}" | ||
| unzip -o /tmp/scripts.zip -d "${SCRIPTS_DIR}" | ||
| # Chmod to work around https://github.com/coder/coder/issues/10034 | ||
| chmod +x "${SCRIPTS_DIR}"/*.sh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8556