Skip to content

feat: add customizable ttl_bump interval #10566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

feat: add customizable ttl_bump interval #10566

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bff9547
feat: add customizable ttl_bump interval
Emyrk Nov 7, 2023
bbbff52
Add ttl bump to template create/update
Emyrk Nov 7, 2023
b0964f0
Extend existing test
Emyrk Nov 8, 2023
68832a5
Fix test assertion
Emyrk Nov 8, 2023
107b9c8
Add workspace ttl bump
Emyrk Nov 9, 2023
8c8adae
WIP
Emyrk Nov 9, 2023
56f0d90
Add unit tests, prevent deadline decrease
Emyrk Nov 9, 2023
55be6f4
Merge remote-tracking branch 'origin/main' into stevenmasley/ttl_bump…
Emyrk Nov 9, 2023
fa11cbd
remove behavior to try and no op defaults
Emyrk Nov 9, 2023
9ceba32
Fix audit table
Emyrk Nov 9, 2023
469228d
cli fields
Emyrk Nov 9, 2023
c1ec0cc
add to workspace create cli command
Emyrk Nov 9, 2023
c02985f
do not use owner in test
Emyrk Nov 10, 2023
2a9713b
make gen
Emyrk Nov 13, 2023
4e295f8
update golden file
Emyrk Nov 13, 2023
b47e63f
Add ui to adjust default activty bump
Emyrk Nov 13, 2023
161875b
Add ui for workspace scheduling
Emyrk Nov 13, 2023
97adb66
Fix test assertion
Emyrk Nov 13, 2023
f28d474
make fmt
Emyrk Nov 13, 2023
4fb280c
fix activity bump sql
Emyrk Nov 13, 2023
51e251f
Merge remote-tracking branch 'origin/main' into stevenmasley/ttl_bump…
Emyrk Nov 13, 2023
18b09e9
Pass in an actual value for the bump
Emyrk Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix activity bump sql
  • Loading branch information
@Emyrk
Emyrk committed Nov 13, 2023
commit 4fb280cc29cdbdf499f6beea2a3f8b5f2b7d4f90
2 changes: 1 addition & 1 deletion coderd/database/queries.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion coderd/database/queries/activitybump.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ WITH latest AS (
END
ELSE
CASE
WHEN templates.ttl_bump > 0 THEN (templates.ttl_bump / 1000 / 1000 / 1000 || ' seconds')::interval
WHEN templates.default_ttl_bump > 0 THEN (templates.default_ttl_bump / 1000 / 1000 / 1000 || ' seconds')::interval
ELSE (templates.default_ttl / 1000 / 1000 / 1000 || ' seconds')::interval
END
END
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/WorkspaceSettingsPage/WorkspaceSchedulePage/WorkspaceSchedulePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ describe("WorkspaceSchedulePage", () => {
// zero
[0, 0, { autostopEnabled: false, ttl: 0, ttl_bump: 0 }],
// basic case
[28_800_000, 3600, { autostopEnabled: true, ttl: 8, ttl_bump: 1 }],
[28_800_000, 3600, { autostopEnabled: true, ttl: 8, ttl_bump: 0 }],
] as const)(
`ttlMsToAutostop(%p) returns %p`,
(ttlMs, ttlBumpMs, autostop) => {
Expand Down