Skip to content

chore(site): remove workspace schedule banner service #10588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2023
Merged

chore(site): remove workspace schedule banner service #10588

merged 4 commits into from
Nov 8, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to #9943

@BrunoQuaresma BrunoQuaresma requested a review from a team November 8, 2023 14:07
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 8, 2023
@BrunoQuaresma BrunoQuaresma requested review from aslilac and Parkreiner and removed request for a team November 8, 2023 14:07
aslilac
aslilac requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single use hooks bad >:( (but otherwise looks good)

@BrunoQuaresma BrunoQuaresma requested a review from aslilac November 8, 2023 17:41
aslilac
aslilac approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, thank you thank you 💕

@BrunoQuaresma BrunoQuaresma merged commit a328d20 into main Nov 8, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/remove-schedule-banner-service branch November 8, 2023 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

@Parkreiner Parkreiner Awaiting requested review from Parkreiner

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @aslilac