chore: add automaxprocs to limit parallel processes inside containers #10594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw this post on HackerNews: https://www.riverphillips.dev/blog/go-cfs/. It seems like we could benefit from this as well, because Coder is so frequently deployed in a container.
mafredri
approved these changes
Nov 8, 2023
|
Great idea. Will do! |
|
@kylecarbs I'm re-opening this since I'm good with having this merged. Seems there's a tiny lint issue remaining, but raising the cyclo limit seems fine for this PR (+1). |
mafredri
reviewed
Nov 20, 2023
Comment on lines
+165
to
+169
| undoMacProcs, err := limitGoMaxProcs(logger) | ||
| if err != nil { | ||
| return xerrors.Errorf("set maxprocs: %w", err) | ||
| } | ||
| defer undoMacProcs() |
There was a problem hiding this comment.
Suggested change
| undoMacProcs, err := limitGoMaxProcs(logger) | |
| if err != nil { | |
| return xerrors.Errorf("set maxprocs: %w", err) | |
| } | |
| defer undoMacProcs() | |
| undoMaxProcs, err := limitGoMaxProcs(logger) | |
| if err != nil { | |
| return xerrors.Errorf("set maxprocs: %w", err) | |
| } | |
| defer undoMaxProcs() |
(PS. Also other instances of mac procs 😄)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this post on HackerNews: https://www.riverphillips.dev/blog/go-cfs/. It seems like we could benefit from this as well, because Coder is so frequently deployed in a container.