Skip to content

chore: refactor ResolveAutostart tests to use dbfake #10603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 1, 2023
Merged

chore: refactor ResolveAutostart tests to use dbfake #10603

merged 11 commits into from
Dec 1, 2023

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Nov 9, 2023

No description provided.

@sreya sreya requested a review from spikecurtis November 9, 2023 08:20
spikecurtis
spikecurtis reviewed Nov 13, 2023
View reviewed changes
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 21, 2023
@github-actions github-actions bot closed this Nov 25, 2023
@sreya sreya reopened this Nov 27, 2023
@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 28, 2023
@sreya sreya requested a review from spikecurtis November 30, 2023 03:33
spikecurtis
spikecurtis approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggestions inline, but I don't need to review again

@sreya sreya merged commit 967db28 into main Dec 1, 2023
@sreya sreya deleted the jon/refautostart branch December 1, 2023 01:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@sreya sreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @spikecurtis